Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make tags additive to CLI tags #99

Closed
peterneubauer opened this issue Jan 21, 2015 · 1 comment
Closed

make tags additive to CLI tags #99

peterneubauer opened this issue Jan 21, 2015 · 1 comment

Comments

@peterneubauer
Copy link

in https://github.com/aphyr/riemann-tools/blob/master/lib/riemann/tools.rb#L58, the tags coming from something like

report(
      :service => "test",
      :metric => 1,
      :state => "ok",
      :tags => ["test"]
  )

are ignored if there also are command line tags set. I would suggest to combine them for better handling instead of silently ignoring them?

@jamtur01
Copy link
Member

jamtur01 commented Feb 6, 2016

Hi @peterneubauer Any chance you could test the attached patch and make sure it works for you? Thanks!

jamtur01 added a commit that referenced this issue Feb 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants