Adding support for https connection #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -17,6 +17,7 @@ class Riemann::Tools::Rabbitmq | |||
| opt :monitor_pass, 'RabbitMQ monitoring user password', type: :string | |||
| opt :monitor_port, 'RabbitMQ monitoring port', type: :int, default: 15672 | |||
| opt :monitor_host, 'RabbitMQ monitoring host', type: :string, default: "localhost" | |||
| opt :monitor_ssl, 'RabbitMQ ssl', type: :string, default: "false" | |||
There was a problem hiding this comment.
I might actually call this :monitor_tls since it's TLS, not SSL, right? Or maybe have it be a string but call it :protocol?, and have values be http or https?
There was a problem hiding this comment.
Yeah, a protocol string might be easiest but too verbose. I it is a string, why not expose "url" to provide custom schemes overriding the rest?
There was a problem hiding this comment.
I agree. Let's just go for a boolean then and I'll be happy to merge. :)
|
Done. |
|
Terrific, thanks so much @peterneubauer! Released as a part of riemann-tools 0.2.4, available now. :) |
aphyr
added a commit
that referenced
this pull request
Jan 26, 2015
Adding support for https connection
|
Scratch that, 0.2.5, sorry. :) |
|
Awesome, thanks for the fast merge @aphyr ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #101