Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip network metric comparison for newly added interfaces #113

Merged
merged 1 commit into from
Mar 24, 2015
Merged

Skip network metric comparison for newly added interfaces #113

merged 1 commit into from
Mar 24, 2015

Conversation

md5
Copy link
Contributor

@md5 md5 commented Mar 24, 2015

Fixes #112

@aphyr
Copy link
Collaborator

aphyr commented Mar 24, 2015

Woo! Terrific. :)

aphyr added a commit that referenced this pull request Mar 24, 2015
@aphyr
Merge pull request #113 from md5/fix-riemann-net-interface-changes
b6ab476 
Skip network metric comparison for newly added interfaces
@aphyr aphyr merged commit b6ab476 into riemann:master Mar 24, 2015
@md5 md5 deleted the fix-riemann-net-interface-changes branch March 24, 2015 16:31
@md5
Copy link
Contributor Author

md5 commented Mar 24, 2015

Would it also be worthwhile to proactively report a state: :expired when a service is found in @old_state that isn't in the new state?

@aphyr
Copy link
Collaborator

aphyr commented Mar 24, 2015

Sure thing!

@md5 md5 mentioned this pull request Mar 28, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in riemann-net when new interfaces are added
2 participants
@md5 @aphyr