Change the way ioreqs metric is handled
#117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_flight` field which is the only field that should/might go to zero. It's better to report the metric as it, without modification. Source : - https://www.kernel.org/doc/Documentation/block/stat.txt - https://www.kernel.org/doc/Documentation/iostats.txt
|
I'm fine with both. :) |
aphyr
added a commit
that referenced
this pull request
Jul 13, 2015
Change the way `ioreqs` metric is handled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indeed, it refers to the
in_flightfield in diskstat file and is the only field that should/might go to zero. I think it's better to report the metric as it, without modification.It might also be worth to rename the metric name.
Source :