Added docker-health tool #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| # Get CPU, Memory and Load of each container | ||
| containers = get_containers() | ||
| containers.each do |container| |
There was a problem hiding this comment.
Parallel For-each would have been better here.
|
very nice |
shanielh
force-pushed
the
master
branch
5 times, most recently
from
195ad30 to
7996620
Compare
|
Hi @aphyr , 19 days passed and I haven't got your response to this pull request, meanwhile I'm using this script in my environment and I've done some fixes to it. If you want me to update the pull request please respond, I will be happy to share it. |
|
Seems good to me! Thanks @shanielh. Sorry bout the delay, been incredibly busy with work and conferences recently. |
|
Kyle I've added some changes to this. I'll pull request later today. — שני. On Sun, Sep 27, 2015 at 2:16 AM, Kyle Kingsbury [email protected]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I've created the docker-health tool that I was talking about in #119
It works using the docker remote API and the
/container/_/statscommand (without stream).Some open issues :
hostthat given for each container is determined by the host and container name (eg.host-container)loadoption for this one, because the tick time is every 10 seconds, I think that it's alright, If people will wantload, they can use riemann streams to mimic the behaviourriemann-healthtooldocker-apigemThis is how it looks