Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splits out individual programs to GitHub Riemann org #136

Merged
merged 11 commits into from
Jan 20, 2016
Merged

Splits out individual programs to GitHub Riemann org #136

merged 11 commits into from
Jan 20, 2016

Conversation

jamtur01
Copy link
Member

This series of commits:

  1. Moves each Riemann binary program to a new repo under the GitHub Riemann org.
  2. Rewrites documentation to reflect this.
  3. Cleans up Rakefile and associated to reflect this.

Currently none of the extracted programs have been pushed as gems so this is mostly an "on paper" exercise. When they are all pushed as Gems then we'll need to increment the version on this gem, add some warning text and re-push.

@jamtur01 jamtur01 mentioned this pull request Jan 19, 2016
@fborgnia
Copy link
Member

I like this, though not 100% sure on splitting out those executables that only require riemann-tools IE: riemann-health, -fd, -diskstats, -net...

@jamtur01
Copy link
Member Author

@fborgnia I considered that and then decided that either Riemann-tools was a framework/scaffold or it wasn't - if that makes sense?

@fborgnia
Copy link
Member

both the repo and gem name suggests to me a set of basic tools, not only scaffolding, besides that i dont see any benefit from splitting those execs that don't require anything else.

@jamtur01
Copy link
Member Author

I guess I think it's confusing. Some of the tools are in one gem and a bunch are not. Feels like a mixed signal. If most folks are managing this with configuration management this allows then to be explicit and granular.

@jamtur01
Copy link
Member Author

After discussions with @aphyr we're going to wind some of this back - new rule of thumb - broadly tools with dependencies are separate and others are in the riemann-tools gem.

@jamtur01
Copy link
Member Author

I've updated the branch to only remove those with dependencies.

aphyr added a commit that referenced this pull request Jan 20, 2016
Splits out individual programs to GitHub Riemann org
@aphyr aphyr merged commit 41a90e8 into riemann:master Jan 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants