Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix overflowing text from ps by swapping args for comm #17

Merged
merged 1 commit into from
Nov 25, 2012
Merged

fix overflowing text from ps by swapping args for comm #17

merged 1 commit into from
Nov 25, 2012

Conversation

dch
Copy link
Contributor

@dch dch commented Nov 22, 2012

Instead of sending full arguments list of process output, only send the command name.

fixes #16

On systems with multiple daemons and complex command lines running, it seems riemann-tools gets confused. There might be an underlying issue that causes UDP overflow, but this workaround seems sensible anyway.

  • works on OSX
  • works on ubuntu precise
  • probably works on all reasonable unixes

On http://unixhelp.ed.ac.uk/CGI/man-cgi?ps find comm for what changed, or man ps.

@aphyr
Copy link
Collaborator

aphyr commented Nov 25, 2012

I'm up for this; typically args just get in the way. I still need to fix the underlying bug; riemann should automatically switch to TCP for large messages.

aphyr added a commit that referenced this pull request Nov 25, 2012
fix overflowing text from ps by swapping args for comm
@aphyr aphyr merged commit 719c999 into riemann:master Nov 25, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

riemann-health EMSGSIZE Message too long - sendto(2) on OSX
2 participants