Default event hostname #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I totally agree that the distinction's hard to make; the only problem I have with event-host is that it doesn't seem to like that as a symbol in Ruby. opt :event-host, "Event hostname", :type => StringOther preferences? Plain :name? :eventhost? I'm open to anything, really. Tell me what you'd like and I'll make the change. :-) |
Useful when trying `riemann-health` on a box to which you don't have access to change the hostname—like Heroku where `hostname` returns a GUID that's meaningless to you.
|
Odd; force-pushing to my fork seemed to nuke your comments from this PR. Fantastic tip about Trollup allowing |
|
Thanks so much Tim! I've added you to the contributors file. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful when trying riemann-health on a box to which you don't have access to change the hostname—like Heroku where
hostnamereturns a GUID that's meaningless to you.