Allow riemann resmon to use hostname or FQDN for events #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 1, 2013 18:36
By default riemann-resmon was using the FQDN of the server it was checking as the event hostname. This was slightly annoying as it meant that went submitting metrics from an application you had to submit as the FQDN. This change allows you to select the behaviour, by default it will use the hostname of the server it is checking.
…emann_resmon_host_config
|
@aphyr We've been using this in production with no problems. Wasn't sure if I should merge it in, or if you'd want to take a look over it (merging my own work I might miss something glaringly wrong!). |
|
Yeah, I tend to want riemann-tools to use the local system's hostname as well, since I deploy these scripts as a part of the standard build pointing to localhost. :) +1 |
aphyr
added a commit
that referenced
this pull request
May 22, 2013
Allow riemann resmon to use hostname or FQDN for events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default riemann-resmon was using the FQDN of the server it was
checking as the event hostname. This was slightly annoying as it meant
that went submitting metrics from an application you had to submit as
the FQDN.
This change allows you to select the behaviour, by default it will use
the hostname of the server it is checking.