Riemann mysql client #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| data = { | ||
| :host => opts[:mysql_host], | ||
| :service => "mysql #{var["Variable_name"]}", | ||
| :metric => var["Value"].to_f, |
There was a problem hiding this comment.
Strings would get coerced to a float here, might be good to save them and set as an attribute, or set them as the description for the service?
|
Looks good 👍 I'd change the metric so that it doesn't submit strings as floats. Are you using the state? I see it's being set as a string, which will send up with states like: |
|
@gsandie yeap sounds good, i'm not actually using the states so nil will work fine, thanks for taking a look. |
send metric as returned from query
|
@fborgnia Excellent looks good, thanks :) |
|
@gsandie thanks for the quick merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added riemann-mysql that reports to riemann server the results of "SHOW STATUS" query.