Add support for some extra Riak stats #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `node_gets_set` and `node_puts_set` to core_services, to catch Set get/put stats. Signed-off-by: Gergely Nagy <[email protected]>
This changes how the fsm stats work, so we can add support for `node_get_fsm_objsize_*` too, with as little code change as possible. Signed-off-by: Gergely Nagy <[email protected]>
|
This looks solid to me, @algernon. Does it test OK with your Riak setup? If so, I'll merge and we'll be good to go. :) |
|
Yep. Works fine. |
aphyr
added a commit
that referenced
this pull request
Nov 10, 2014
Add support for some extra Riak stats
|
Thank you, Gergely. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to monitor the
node_gets_set,node_puts_setstatistics, along with thenode_fsm_get_set_objsize_*family of stats. This pull request adds both, although the latter in a very hackish way, which should likely be done better.But my ruby is quite weak, and my time limited, so I wanted to get this out here ASAP. I can reshape the patches - especially the second - later, if so need be.