Monitor RabbitMQ queue sizes and node memory/disk health

[mpalmer]

No description provided.

[aphyr]

Wait, isn't riemann-rabbitmq a part of the riemann-tools gem still? We can't depend on the gem this way unless it's a separate dep, right?

[aphyr]

This looks mostly good, just want to be reassured about the require change and we'll be set! It's been a while since I've done ruby packaging so I don't want to accidentally break anything. :)

[mpalmer]

On a system with RubyGems activated (ie 1.9+ by default, or 1.8 with RUBYOPT=-rubygems) require is implemented in such a way that gems installed on the system will be scanned for the existence of the named file, and will activate the gem (ie add it to $LOAD_PATH) that contains the file, if one is found.

On a more concrete note, a patched riemann-rabbitmq, in a rebuilt gem, with this change is running quite happily for me on several machines now, so I'm pretty confident it won't break anything.

[aphyr]

Yeah, the question is more which copy of the code it refers to. The reason I require the local copy is because when you're hacking on riemann-tools proper, you want those changes to be reflected in the tools themselves. If I understand correctly, this require line will read the installed rubygems copy of riemann/tools.rb, not the local copy.

[aphyr]

Just gonna merge this and flip back the require line. :)