forked from finos/FDC3
-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #2 from finos/master
upstream
- Loading branch information
Showing
143 changed files
with
6,587 additions
and
3,353 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,18 +11,22 @@ must be made with a | |
in place, and there are [additional legal requirements](https://finosfoundation.atlassian.net/wiki/spaces/FINOS/pages/75530375/Legal+Requirements) | ||
that must also be met.** | ||
|
||
Commits and pull requests to FINOS repositories such as FDC3 will only be accepted from those contributors with an active, executed Individual Contributor License Agreement (ICLA) with FINOS OR who are covered under an existing and active Corporate Contribution License Agreement (CCLA) executed with FINOS. Commits from individuals not covered under an ICLA or CCLA will be flagged and blocked by the FINOS ["CLA Bot" tool](https://github.com/finos/cla-bot). Please note that some CCLAs require individuals/employees to be explicitly named on the CCLA. | ||
|
||
As a result, PRs submitted to the FDC3 project cannot be accepted until you have a CLA in place with the Foundation. | ||
|
||
Need an ICLA? Unsure if you are covered under an existing CCLA? Email [[email protected]](mailto:[email protected]?subject=CLA) | ||
|
||
# Contributing Issues | ||
|
||
## Prerequisites | ||
|
||
* [ ] Have you [searched for duplicates](https://github.com/FDC3/FDC3/issues?utf8=%E2%9C%93&q=)? A simple search for exception error messages or a summary of the unexpected behaviour should suffice. | ||
* [ ] Have you [searched for duplicates](https://github.com/finos/FDC3/issues?utf8=%E2%9C%93&q=)? A simple search for exception error messages or a summary of the unexpected behaviour should suffice. | ||
* [ ] Are you running the latest version? | ||
* [ ] Are you sure this is a bug or missing capability? | ||
|
||
## Raising an Issue | ||
* Create your issue [here](https://github.com/FDC3/FDC3/issues/new). | ||
* Create your issue [here](https://github.com/finos/FDC3/issues/new). | ||
* New issues contain two templates in the description: bug report and enhancement request. Please pick the most appropriate for your issue, **then delete the other**. | ||
* Please also tag the new issue with either "Bug" or "Enhancement". | ||
* Please use [Markdown formatting](https://help.github.com/categories/writing-on-github/) | ||
|
@@ -34,12 +38,12 @@ To make review of PRs easier, please: | |
|
||
* Please make sure your PRs will merge cleanly - PRs that don't are unlikely to be accepted. | ||
* For code contributions, follow the existing code layout. | ||
* For documentation contributions, follow the general structure, language, and tone of the [existing docs](https://github.com/FDC3/FDC3/wiki). | ||
* For documentation contributions, follow the general structure, language, and tone of the [existing docs](https://github.com/finos/FDC3/wiki). | ||
* Keep commits small and cohesive - if you have multiple contributions, please submit them as independent commits (and ideally as independent PRs too). | ||
* Reference issue #s if your PR has anything to do with an issue (even if it doesn't address it). | ||
* Minimise non-functional changes (e.g. whitespace shenanigans). | ||
* Ensure all new files include a header comment block containing the [Apache License v2.0 and your copyright information](http://www.apache.org/licenses/LICENSE-2.0#apply). | ||
* If necessary (e.g. due to 3rd party dependency licensing requirements), update the [NOTICE file](https://github.com/FDC3/FDC3/blob/master/NOTICE) with any new attribution or other notices | ||
* If necessary (e.g. due to 3rd party dependency licensing requirements), update the [NOTICE file](https://github.com/finos/FDC3/blob/master/NOTICE) with any new attribution or other notices | ||
|
||
|
||
## Commit and PR Messages | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
FDC3 - FINOS | ||
Copyright 2017 FDC3 info@finos.org | ||
Copyright 2017-2019 OpenFin info@openfin.co | ||
|
||
This product includes software developed at the Fintech Open Source Foundation (https://www.finos.org/). | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.