Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDKv2 #27

Merged
merged 6 commits into from
Jan 9, 2023
Merged

CDKv2 #27

merged 6 commits into from
Jan 9, 2023

Conversation

giantcow
Copy link
Contributor

@giantcow giantcow commented Jan 8, 2023

  • Upgrades to CDKv2
  • Adds snapshot tests
  • Moves configuration for lloesche/valheim-server-docker into environment variables, utilizing dotenv.
  • Determine if we should build the APIGW stack if the user sets a password that isn't "changeme"
  • Upgrades APIGW Lambdas from 10.x to 18.x
    • These need tests

I can't guarantee that this will work flawlessly with existing CDKv1 stacks, but it should work

@giantcow
Copy link
Contributor Author

giantcow commented Jan 8, 2023

Sonar is complaining about the APIGW authentication, which is a fair call TBH. We should lock that APIGW behind an IAM Role.

I'm kinda leaning towards saying "whatever it's just a game server", and just letting it be.. I do have some ideas to expand on the idea this package has into a more generic abstraction but I need to put a lot more thought into that.

@giantcow
Copy link
Contributor Author

giantcow commented Jan 8, 2023

Should also mention that I'm working on another branch in my fork to allow users to bootstrap the docker image with an existing world file, but it's not working at the moment: https://github.com/RyoshiKayo/valheim-ecs-fargate-cdk/tree/bootstrap-world

Edit: Bootstrapping is working now, will send over another PR once this PR is merged: giantcow@982ef2f

Edit 2: I forgot github automatically updates PR's so I guess it's in this PR now lol

Kayo added 2 commits January 8, 2023 22:46
* feat: Allow users to bootstrap with an existing world save
* fix (bootstrapping): Change logic for copying world files
* feat (fg-service): set minHealthyPercentage to zero and allow docker-exec
* docs: Add world bootstrapping and docker-exec info
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 4 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 6 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rileydakota
Copy link
Owner

@RyoshiKayo love the PR work! FWIW - I dont believe we need to be terribly concerned with backwards compatibility (re: CDKv1 stacks). I imagine players revisit often.

I love the check for changing of the default creds too!

@rileydakota rileydakota merged commit 2a34dfd into rileydakota:main Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants