-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CDKv2 #27
CDKv2 #27
Conversation
Accidently removed this in the CDKv2 migration because types are hard
Sonar is complaining about the APIGW authentication, which is a fair call TBH. We should lock that APIGW behind an IAM Role. I'm kinda leaning towards saying "whatever it's just a game server", and just letting it be.. I do have some ideas to expand on the idea this package has into a more generic abstraction but I need to put a lot more thought into that. |
Should also mention that I'm working on another branch in my fork to allow users to bootstrap the docker image with an existing world file,
Edit 2: I forgot github automatically updates PR's so I guess it's in this PR now lol |
* feat: Allow users to bootstrap with an existing world save * fix (bootstrapping): Change logic for copying world files * feat (fg-service): set minHealthyPercentage to zero and allow docker-exec * docs: Add world bootstrapping and docker-exec info
SonarCloud Quality Gate failed. 4 Bugs No Coverage information |
@RyoshiKayo love the PR work! FWIW - I dont believe we need to be terribly concerned with backwards compatibility (re: CDKv1 stacks). I imagine players revisit often. I love the check for changing of the default creds too! |
I can't guarantee that this will work flawlessly with existing CDKv1 stacks, but it should work