Skip to content

Commit

Permalink
fix: test
Browse files Browse the repository at this point in the history
  • Loading branch information
mindspank committed Feb 4, 2025
1 parent 4d38d00 commit bc95a36
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 16 deletions.
3 changes: 0 additions & 3 deletions web-local/tests/explores/explores.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,6 @@ test.describe("explores", () => {
await page.getByRole("menuitem", { name: "All Time" }).click();
});

// Turn on comparison
await page.getByRole("button", { name: "Comparing" }).click();

// Check the total records are 100k
await expect(page.getByText("Total records 100k")).toBeVisible();

Expand Down
21 changes: 11 additions & 10 deletions web-local/tests/explores/leaderboard-and-dim-table-sort.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,17 @@ test.describe("leaderboard and dimension table sorting", () => {
test("leaderboard and dimension table sorting", async ({ page }) => {
await page.waitForTimeout(1000);

const timeRangeMenu = page.getByRole("button", {
name: "Select time range",
});

async function openTimeRangeMenu() {
await timeRangeMenu.click();
await page
.getByRole("menu", { name: "Select time range" })
.waitFor({ state: "visible" });
}

await openTimeRangeMenu();
await page.getByRole("menuitem", { name: "All Time" }).click();

Expand All @@ -40,16 +51,6 @@ test.describe("leaderboard and dimension table sorting", () => {
page.getByRole("row", { name: "null 32.9k" }),
);

const timeRangeMenu = page.getByRole("button", {
name: "Select time range",
});

async function openTimeRangeMenu() {
await timeRangeMenu.click();
await page
.getByRole("menu", { name: "Select time range" })
.waitFor({ state: "visible" });
}

await assertAAboveB(
page.getByRole("row", { name: "Microsoft 10.4k" }),
Expand Down
6 changes: 3 additions & 3 deletions web-local/tests/utils/dataSpecifcHelpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,11 @@ export async function assertAdBidsDashboard(page: Page) {
values: [
"facebook.com",
"msn.com",
"google.com",
"news.google.com",
"sports.yahoo.com",
"news.yahoo.com",
"google.com",
"instagram.com",
"sports.yahoo.com",
"news.google.com",
],
},
]),
Expand Down

0 comments on commit bc95a36

Please sign in to comment.