Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Metric View as refreshable resources to CLI #6589

Merged
merged 7 commits into from
Feb 5, 2025

Conversation

grahamplata
Copy link
Contributor

@grahamplata grahamplata commented Feb 4, 2025

Enables the user to re-trigger of validation of a metrics view in the same way that we support refresh of e.g. sources or the parser.

rill project refresh --metrics-view <NAME>

Relates to: #6492


go run ./cli project refresh --metrics-view auction_metrics --project dev-project
{"level":"info","ts":1738699846.999189,"msg":"Reconciling resource","instance_id":"bd9e3faa5d454b768f63989b60eac615","name":"auction_metrics","type":"MetricsView"}
{"level":"info","ts":1738699847.023925,"msg":"Reconciled resource","instance_id":"bd9e3faa5d454b768f63989b60eac615","name":"auction_metrics","type":"MetricsView","elapsed":0.025}

Sample trigger from local devtool

@grahamplata grahamplata self-assigned this Feb 4, 2025
@grahamplata grahamplata marked this pull request as ready for review February 4, 2025 20:24
@begelundmuller begelundmuller merged commit 36b8a65 into main Feb 5, 2025
8 checks passed
@begelundmuller begelundmuller deleted the gplata/metric-validation-trigger branch February 5, 2025 13:44
begelundmuller added a commit that referenced this pull request Feb 5, 2025
* update refresh with metric view flag

* update reconciler trigger to handle view

* generate cli docs

* adjust spec

* Review

* Lint

* Typo

---------

Co-authored-by: Benjamin Egelund-Müller <[email protected]>
begelundmuller added a commit that referenced this pull request Feb 5, 2025
* update refresh with metric view flag

* update reconciler trigger to handle view

* generate cli docs

* adjust spec

* Review

* Lint

* Typo

---------

Co-authored-by: Benjamin Egelund-Müller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants