Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leverage nftoken_id, nftoken_ids and offer_id meta fields in transaction parsers #1018

Merged
merged 10 commits into from
Jul 18, 2024

Conversation

achowdhry-ripple
Copy link
Collaborator

High Level Overview of Change

utilize added ID fields based on this rippled PR, rather than manually parsing for NFToken transactions.

Context of Change

#708

Type of Change

Code Improvement

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Translation Updates
  • Release

TypeScript/Hooks Update

  • Updated files to React Hooks
  • Updated files to TypeScript

@achowdhry-ripple
Copy link
Collaborator Author

for cancel offer, I purposely do not use meta.nftoken_ids[] to keep logic simple, since we iterate nodes for other fields. Seems like added complexity to use the meta field here.

@achowdhry-ripple achowdhry-ripple marked this pull request as ready for review July 10, 2024 20:11
@pdp2121 pdp2121 requested review from mvadari and pdp2121 July 11, 2024 14:34
Copy link
Collaborator

@pdp2121 pdp2121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ckeshava ckeshava merged commit 16c3676 into staging Jul 18, 2024
4 checks passed
@ckeshava ckeshava deleted the nftoken-meta-fields branch July 18, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants