Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OpenSSL 1.1.0 #2151

Closed
wants to merge 1 commit into from
Closed

Support OpenSSL 1.1.0 #2151

wants to merge 1 commit into from

Conversation

JoelKatz
Copy link
Collaborator

Work around differences between OpenSSL 1.0 and 1.1 to permit compiling on distributions that use newer versions. This involves using conditional compilation to remove workarounds that are no longer needed. Fedora 26 is coming out shortly and will need this.

Work around differences between OpenSSL 1.0 and 1.1 to
permit compiling on distributions that use newer versions.
@codecov-io
Copy link

Codecov Report

Merging #2151 into develop will decrease coverage by 0.02%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2151      +/-   ##
===========================================
- Coverage    69.01%   68.99%   -0.03%     
===========================================
  Files          684      684              
  Lines        50468    50449      -19     
===========================================
- Hits         34833    34809      -24     
- Misses       15635    15640       +5
Impacted Files Coverage Δ
src/ripple/beast/asio/ssl_error.h 90.9% <ø> (ø) ⬆️
src/ripple/basics/impl/make_SSLContext.cpp 48.55% <71.42%> (-4.96%) ⬇️
src/ripple/app/ledger/PendingSaves.h 93.54% <0%> (-6.46%) ⬇️
src/ripple/app/misc/SHAMapStoreImp.cpp 78.86% <0%> (-1.04%) ⬇️
src/ripple/server/impl/BaseWSPeer.h 67.5% <0%> (-0.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b0d482...86e9c04. Read the comment docs.

RSA* rsa = RSA_generate_key (n_bits, RSA_F4, nullptr, nullptr);
#endif
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested way to hold these resources: HowardHinnant@720aa29

@nbougalis
Copy link
Contributor

Merged as f9b5ab4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants