Report additional fields in validation stream #3865
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcobb23
approved these changes
Jun 17, 2021
ximinez
requested changes
Jul 6, 2021
src/ripple/app/misc/NetworkOPs.cpp
Outdated
Comment on lines
2012
to
2020
| if (auto version = (*val)[~sfServerVersion]; version) | ||
| jvObj[jss::server_version] = std::to_string(*version); | ||
|
|
||
| if (auto cookie = (*val)[~sfCookie]; cookie) | ||
| jvObj[jss::cookie] = std::to_string(*cookie); | ||
|
|
||
| if (auto hash = (*val)[~sfValidatedHash]; hash) | ||
| jvObj[jss::validated_hash] = strHex(*hash); | ||
|
|
There was a problem hiding this comment.
The second check in all of these are redundant. In other words,
if(auto x = X(); x)
foo;
can be written as:
if(auto x = X())
foo;
There was a problem hiding this comment.
Thanks @ximinez, I believe I've addressed your comment with the most recent commit.
There was a problem hiding this comment.
So that was a human that called me today my bad bud
SirJosh1987
approved these changes
Jul 9, 2021
|
@miguelportilla, would you like to weigh in on this pull request? Or are you happy enough with reviews from @cjcobb23 and @ximinez? Whatever you'd like. Thanks. |
|
Private communications suggest that @miguelportilla is currently tied up with other matters. Given that we have approval from two reviewers, I'm going to squash this branch and, assuming it passes CI after the squash, mark it as passed. |
The HardenedValidations amendment introduces additional fields in validations: - `sfValidatedHash`, if present, is the hash the of last ledger that the validator considers to be fully validated. - `sfCookie`, if present, is a 64-bit cookie (the default implementation selects it randomly at startup but other implementations are possible), which can be used to improve the detection and classification of duplicate validations. - `sfServerVersion`, if present, reports the version of the software that the validator is running. By surfacing this information, server operators gain additional insight about variety of software on the network. If merged, this commit fixes XRPLF#3797 by adding the fields to the `validations` stream as shown below: - `sfValidateHash` as `validated_hash`: a 256-bit hex string; - `sfCookie` as `cookie`: a 64-bit integer as a string; and - `sfServerVersion` as `server_version`: a 64-bit integer as a string.
scottschurr
added
the
Passed
Merged
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch was initially created by @nbougalis, who is currently too busy to shepherd the pull request through the review. So I'm re-opening the pull request in a form where I can easily handle any requests for changes.
Overview
The HardenedValidations amendment introduces additional fields in validations:
sfValidatedHash, if present, is the hash the of last ledger that the validator considers to be fully validated.sfCookie, if present, is a 64-bit cookie (the default implementation selects it randomly at startup but other implementations are possible), which can be used to improve the detection and classification of duplicate validations.sfServerVersion, if present, reports the version of the software that the validator is running. By surfacing this information, server operators gain additional insight about variety of software on the network.If merged, this commit fixes #3797 by adding the fields to the
validationsstream as shown below:sfValidateHashasvalidated_hash: a 256-bit hex string;sfCookieascookie: a 64-bit integer as a string; andsfServerVersionasserver_version: a 64-bit integer as a string.Type of Change
Tagging @wilsonianb who originally opened #3797.