Node to shard control #3875
Closed
Node to shard control #3875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
undertome
force-pushed
the
node-to-shard-control
branch
from
5ad9f80 to
90c2126
Compare
undertome
force-pushed
the
node-to-shard-control
branch
2 times, most recently
from
e34482f to
3280111
Compare
ximinez
requested changes
Jul 15, 2021
There was a problem hiding this comment.
Fails to build under Windows. Here's the fix: ximinez@d4e26b0
Consider pulling that lambda into a separate function, since it's duplicated.
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Jul 15, 2021
This fix has been included in XRPLF#3875, so watch out for merge conflicts
Done |
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Jul 27, 2021
This fix has been included in XRPLF#3875, so watch out for merge conflicts
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Jul 28, 2021
This fix has been included in XRPLF#3875, so watch out for merge conflicts
undertome
force-pushed
the
node-to-shard-control
branch
from
8ce8744 to
fa41d3c
Compare
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Jul 29, 2021
This fix has been included in XRPLF#3875, so watch out for merge conflicts
ximinez
requested changes
Aug 23, 2021
ximinez
requested changes
Aug 24, 2021
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Sep 15, 2021
This fix has been included in XRPLF#3875, so watch out for merge conflicts
ximinez
requested changes
Sep 21, 2021
ximinez
added a commit
to ximinez/rippled
that referenced
this pull request
Oct 7, 2021
This fix has been included in XRPLF#3875, so watch out for merge conflicts
Update defaults from 20/5 to 10/2 for account and owner reserves respectively. The network has been voting for 10/2 for an adequate period of time and a new server installation should default to the new reserves.
non-existant -> non-existent
undertome
force-pushed
the
node-to-shard-control
branch
from
404d637 to
ca741ec
Compare
* disable build specific commandline options when built without tests
undertome
force-pushed
the
node-to-shard-control
branch
from
ca741ec to
114728a
Compare
This was referenced Oct 18, 2021
Closed
Closed
Merged
12 tasks
legleux
pushed a commit
to legleux/rippled
that referenced
this pull request
Dec 19, 2021
This fix has been included in XRPLF#3875, so watch out for merge conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This change extends the rpc interface by allowing starting, stopping and polling a nodestore to shardstore database import from a single command.
Context of Change
This is a new feature that allows users to control database imports with the following rpc command syntax:
node_to_shard [status|start|stop]This change also includes a bug fix from @ximinez that corrects a false positive in the shard unit tests.
Type of Change