Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for changes from rippled 1.6.0. #16

Closed
wants to merge 0 commits into from
Closed

Update for changes from rippled 1.6.0. #16

wants to merge 0 commits into from

Conversation

ximinez
Copy link
Contributor

@ximinez ximinez commented Jun 25, 2020 •
edited
Loading

This will have to wait until rippled 1.6.0 is released, and assumes it includes XRPLF/rippled#3449 and XRPLF/rippled#3532

This change is Reviewable

@ximinez ximinez mentioned this pull request Jun 25, 2020
Closed
@ximinez ximinez force-pushed the ripple160 branch 10 times, most recently from 50423a3 to 9fcb1df Compare July 10, 2020 23:14
@ximinez ximinez force-pushed the ripple160 branch 15 times, most recently from 12b4e52 to 92f888b Compare July 15, 2020 23:07
@ximinez ximinez marked this pull request as ready for review August 19, 2020 22:56
@ximinez ximinez requested review from seelabs and cjcobb23 August 19, 2020 22:59
pwang200
pwang200 approved these changes Aug 24, 2020
View reviewed changes
Copy link

@pwang200 pwang200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Built and unit-test worked fine on both Ubuntu and Mac, for both release and debug. Command line also worked fine.

The file changes seem good, but I am not good at Travis config, nor an export on Cmake.

cjcobb23
cjcobb23 reviewed Sep 21, 2020
View reviewed changes
Copy link

@cjcobb23 cjcobb23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built for me and unit tests passed as well. cmake seems to always download the rippled source code though, even when I set -DCMAKE_PREFIX_PATH=[path to rippled executable]. Maybe I am doing something wrong though.

@ximinez
Copy link
Contributor Author

ximinez commented Sep 22, 2020

AFAIK, it will show the "-- Pausing to download rippled source..." message regardless. The difference is that if it's already downloaded, it'll just pause for a couple of seconds while it checks. If it's not downloaded, it'll take significantly longer.

@cjcobb23
Copy link

AFAIK, it will show the "-- Pausing to download rippled source..." message regardless. The difference is that if it's already downloaded, it'll just pause for a couple of seconds while it checks. If it's not downloaded, it'll take significantly longer.

That's actually the behavior I saw, where it paused for only a couple of seconds. OK, I will approve then.

@ximinez ximinez mentioned this pull request Sep 28, 2020
Merged
@ximinez ximinez closed this Sep 29, 2020
@ximinez ximinez deleted the ripple160 branch September 29, 2020 18:06
@ximinez ximinez restored the ripple160 branch September 29, 2020 21:55
@ximinez ximinez deleted the ripple160 branch September 30, 2020 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcobb23 cjcobb23 cjcobb23 approved these changes

@pwang200 pwang200 pwang200 approved these changes

@seelabs seelabs Awaiting requested review from seelabs

Assignees

@pwang200 pwang200

@seelabs seelabs

@cjcobb23 cjcobb23

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

can't build validator-keys-tool (Ubuntu18.04)
4 participants
@ximinez @cjcobb23 @pwang200 @seelabs