Improve Visual Studio build check for newer versions #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this file even used? When building the validator-keys-tool I had to update the one in .nih_c coming from the rippled download |
|
It is. Make sure that the rippled download has version 1.9.1, which has this same fix. Basically, this condition gets checked twice - once by validator-keys-tool, once by rippled. If you try to build |
|
Thanks Ed. I had updated manually the KeySanity.cmake last week, but forgot all about it :-), so indeed the change is needed! |
|
@ximinez is this still worth including? Should I merge it? |
@intelliot I think it is, yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically the same change that was included in XRPLF/rippled#4150
Building with the Visual Studio 19 or 22 cmake generators fails because "Win64" is not included in the name. That's because the naming convention was changed between 17 and 19 to not include the architecture, and the default was changed to 64-bit, so the check can be a lot looser.