Add random string in path generation #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: logan-keede <[email protected]>
logan-keede
force-pushed
the
add_random_path
branch
from
5a56fe4 to
e6de68b
Compare
|
@xxchan can this get a review please? |
skyzh
approved these changes
Jan 26, 2025
xxchan
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We encountered an error while running sqllogictest in datafusion.
apache/datafusion#12752
apache/datafusion#14254
This happens when multiple .slt file include from a single parent file while running on multiple threads.
This result in creation of multiple temp file(for parent file) and subsequent failure as these temp files are removed by one thread and then other tries to remove/access it too.
A simple solution is to add a random string to
outfilenameas done in this PR.