add bind_all_columns.

risingwavelabs · Mar 3, 2022 · 6566f98 · 6566f98
1 parent c15800f
commit 6566f98
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 7 deletions.
diff --git a/rust/frontend/src/binder/expr/column.rs b/rust/frontend/src/binder/expr/column.rs
@@ -51,4 +51,17 @@ impl Binder {
             }
         }
     }
+
+    pub fn bind_all_columns(&mut self) -> Result<Vec<ExprImpl>> {
+        let mut bound_columns = vec![];
+        self.context.columns.values().for_each(|columns| {
+            columns.iter().for_each(|column| {
+                bound_columns.push(ExprImpl::InputRef(Box::new(InputRef::new(
+                    column.index,
+                    column.data_type.clone(),
+                ))));
+            });
+        });
+        Ok(bound_columns)
+    }
 }
diff --git a/rust/frontend/src/binder/projection.rs b/rust/frontend/src/binder/projection.rs
@@ -15,7 +15,9 @@ impl Binder {
                 }
                 SelectItem::ExprWithAlias { .. } => todo!(),
                 SelectItem::QualifiedWildcard(_) => todo!(),
-                SelectItem::Wildcard => todo!(),
+                SelectItem::Wildcard => {
+                    select_list.extend(self.bind_all_columns()?.into_iter());
+                }
             }
         }
         Ok(select_list)

diff --git a/rust/frontend/src/planner/select.rs b/rust/frontend/src/planner/select.rs
@@ -2,7 +2,7 @@ use risingwave_common::error::Result;
 
 use crate::binder::BoundSelect;
 use crate::expr::ExprImpl;
-use crate::optimizer::plan_node::{PlanRef, LogicalProject};
+use crate::optimizer::plan_node::{LogicalProject, PlanRef};
 use crate::planner::Planner;
 
 impl Planner {
@@ -25,11 +25,7 @@ impl Planner {
         todo!()
     }
 
-    fn plan_projection(
-        &mut self,
-        input: PlanRef,
-        projection: Vec<ExprImpl>,
-    ) -> Result<PlanRef> {
+    fn plan_projection(&mut self, input: PlanRef, projection: Vec<ExprImpl>) -> Result<PlanRef> {
         // TODO: support alias.
         let expr_alias = vec![None; projection.len()];
         Ok(LogicalProject::create(input, projection, expr_alias))