Skip to content

Commit

Permalink
chore: update comments for dispatcher (#4413)
Browse files Browse the repository at this point in the history
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
  • Loading branch information
xxchan and mergify[bot] authored Aug 4, 2022
1 parent 667ab5d commit 7a0a99d
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions proto/stream_plan.proto
Original file line number Diff line number Diff line change
Expand Up @@ -385,10 +385,11 @@ enum DispatcherType {
// Dispatch by hash key, hashed by consistent hash.
HASH = 1;
// Broadcast to all downstreams.
// TODO: we don't need this as we now support multi-dispatcher per actor.
//
// Note a broadcast cannot be represented as multiple simple dispatchers, since they are
// different when we update dispatchers during scaling.
BROADCAST = 2;
// Only one downstream.
// TODO: seems that same as broadcast dispatch (with only one downstream actor).
SIMPLE = 3;
// A special kind of exchange that doesn't involve shuffle. The upstream actor will be directly
// piped into the downstream actor, if there are the same number of actors. If number of actors
Expand Down

0 comments on commit 7a0a99d

Please sign in to comment.