Skip to content

Commit

Permalink
fix: reduce logging in the critical path (#3704)
Browse files Browse the repository at this point in the history
* fix: reduce logging in the critical path

* fix cargo check

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
  • Loading branch information
neverchanje and mergify[bot] authored Jul 7, 2022
1 parent 79eb45b commit 82ef7ec
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions src/storage/src/hummock/local_version_manager.rs
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,7 @@ impl LocalVersionManager {
}

pub async fn sync_shared_buffer_epoch(&self, epoch: HummockEpoch) -> HummockResult<()> {
info!("sync epoch {}", epoch);
tracing::trace!("sync epoch {}", epoch);
let (tx, rx) = oneshot::channel();
self.buffer_tracker
.send_event(SharedBufferEvent::SyncEpoch(epoch, tx));
Expand All @@ -433,17 +433,18 @@ impl LocalVersionManager {
{
Some(task) => task,
None => {
info!("sync epoch {} has no more task to do", epoch);
tracing::trace!("sync epoch {} has no more task to do", epoch);
return Ok(());
}
};

let ret = self
.run_upload_task(order_index, epoch, task_payload, false)
.await;
info!(
tracing::trace!(
"sync epoch {} finished. Task size {}",
epoch, task_write_batch_size
epoch,
task_write_batch_size
);
if let Some(conflict_detector) = self.write_conflict_detector.as_ref() {
conflict_detector.archive_epoch(epoch);
Expand Down

0 comments on commit 82ef7ec

Please sign in to comment.