Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking: Clean compatible code for legacy frontend #2539

Closed
11 tasks done
fuyufjh opened this issue May 15, 2022 · 1 comment
Closed
11 tasks done

Tracking: Clean compatible code for legacy frontend #2539

fuyufjh opened this issue May 15, 2022 · 1 comment
Labels
component/batch Batch related related issue. component/common Common components, such as array, data chunk, expression. component/meta Meta related issue. type/refactor type/tracking Tracking issue.

Comments

@fuyufjh
Copy link
Member

fuyufjh commented May 15, 2022

Affected components (may be incomplete):


$ ag -i 'Java frontend' .
src/stream/src/from_proto/batch_query.rs
61:            // TODO: remove this branch once we deprecate Java frontend.

src/meta/src/cluster/mod.rs
254:                    // TODO: Java frontend doesn't send heartbeat. Remove this line after using Rust

src/meta/src/stream/fragmenter/mod.rs
44:    // TODO: remove this when we deprecate Java frontend.
263:                    // We didn't make `fields` available on Java frontend yet, so we check if schema
350:                // TODO: Remove this when we deprecate Java frontend.

src/meta/src/barrier/recovery.rs
132:        // Attention, using catalog v2 here, it's not compatible with Java frontend.

src/meta/src/stream/stream_manager.rs
63:    /// TODO: remove this when we deprecate Java frontend.

src/meta/src/rpc/service/epoch_service.rs
23:// TODO: remove EpochService when Java frontend deprecated.

src/common/src/types/chrono_wrapper.rs
137:    /// Converted to microsecond timestamps for compatibility with existing Java frontend.
174:    /// Converted to microsecond timestamps for compatibility with existing Java frontend.

src/common/src/types/mod.rs
95:            // TODO(TaoWu): Java frontend still interprets CHAR as a separate type.
96:            // So to run e2e, we may return VARCHAR that mismatches with what Java frontend
97:            // expected. Fix this when Java frontend fully deprecated.

src/batch/src/executor2/stream_scan.rs
23:// TODO: Remove this when Java frontend is completely removed.

src/batch/src/executor2/insert.rs
112:                // Materialize plan is generated by the optimizer with Java frontend, so we

src/batch/src/executor/create_source.rs
22:// TODO: Remove this when Java frontend is completely removed.
$ ag legacy_frontend .
src/meta/src/stream/stream_manager.rs
64:    pub is_legacy_frontend: bool,
292:            is_legacy_frontend,
323:        if !is_legacy_frontend {

src/meta/src/stream/fragmenter/graph/stream_graph.rs
565:        if ctx.is_legacy_frontend {
598:                    upstream_actor_id: if ctx.is_legacy_frontend {

src/meta/src/stream/fragmenter/mod.rs
45:    is_legacy_frontend: bool,
116:        is_legacy_frontend: bool,
125:            is_legacy_frontend,
351:                current_fragment.is_singleton = self.is_legacy_frontend;

src/meta/src/rpc/service/stream_service.rs
87:            is_legacy_frontend: true,
@fuyufjh fuyufjh added type/tracking Tracking issue. component/batch Batch related related issue. component/meta Meta related issue. component/common Common components, such as array, data chunk, expression. refactor labels May 15, 2022
@skyzh
Copy link
Contributor

skyzh commented May 16, 2022

Also meta's create MV v1 (catalog v1) needs to be removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/batch Batch related related issue. component/common Common components, such as array, data chunk, expression. component/meta Meta related issue. type/refactor type/tracking Tracking issue.
Projects
None yet
Development

No branches or pull requests

4 participants