Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove v2 naming related to legacy frontend #2572

Merged
merged 4 commits into from
May 16, 2022
Merged

Conversation

BugenZhao
Copy link
Member

What's changed and what's your intention?

This PR removes v2 naming from the catalog, risedev, and crate names.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

BugenZhao added 3 commits May 16, 2022 15:37
Signed-off-by: Bugen Zhao <[email protected]>
proto/meta.proto Outdated Show resolved Hide resolved
Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Bugen Zhao <[email protected]>
@BugenZhao BugenZhao enabled auto-merge (squash) May 16, 2022 08:02
@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #2572 (b7b46ea) into main (523b669) will increase coverage by 0.00%.
The diff coverage is 9.09%.

@@           Coverage Diff           @@
##             main    #2572   +/-   ##
=======================================
  Coverage   71.93%   71.93%           
=======================================
  Files         676      676           
  Lines       87551    87546    -5     
=======================================
  Hits        62980    62980           
+ Misses      24571    24566    -5     
Flag Coverage Δ
rust 71.93% <9.09%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/cmd_all/src/bin/risingwave.rs 1.81% <0.00%> (+0.07%) ⬆️
src/cmd_all/src/playground.rs 0.00% <0.00%> (ø)
src/frontend/src/observer/observer_manager.rs 0.00% <0.00%> (ø)
src/meta/src/model/catalog.rs 97.50% <ø> (ø)
src/meta/src/model/mod.rs 95.58% <ø> (ø)
src/risedevtool/src/bin/risedev-playground.rs 0.30% <0.00%> (ø)
src/risedevtool/src/compose.rs 0.00% <0.00%> (ø)
src/risedevtool/src/task.rs 0.00% <ø> (ø)
src/risedevtool/src/task/frontend_service.rs 0.00% <0.00%> (ø)
src/meta/src/manager/catalog.rs 20.00% <22.22%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@BugenZhao BugenZhao merged commit 59a023e into main May 16, 2022
@BugenZhao BugenZhao deleted the bz/remove-v2-naming branch May 16, 2022 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants