Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: alway use pluralized names for repeated fields in proto #4400

Closed
yezizp2012 opened this issue Aug 3, 2022 · 1 comment
Closed

chore: alway use pluralized names for repeated fields in proto #4400

yezizp2012 opened this issue Aug 3, 2022 · 1 comment
Labels
difficulty/simple Issues that relatively easy and friendly to newcomers. good first issue Good for newcomers help wanted Issues that need help from contributors type/feature

Comments

@yezizp2012
Copy link
Member

yezizp2012 commented Aug 3, 2022 •
edited
Loading

Ref: Style Guide | Protocol Buffers
Repeated fields
Use pluralized names for repeated fields.

  repeated string keys = 1;
  ...
  repeated MyMessage accounts = 17;
@yezizp2012 yezizp2012 added type/feature good first issue Good for newcomers help wanted Issues that need help from contributors labels Aug 3, 2022
@yezizp2012 yezizp2012 changed the title chore: allway use pluralized names for repeated fields in proto chore: alway use pluralized names for repeated fields in proto Aug 3, 2022
@BugenZhao
Copy link
Member

FYI, @xxchan renamed all keys to key in our system in #3700.

@skyzh skyzh added the difficulty/simple Issues that relatively easy and friendly to newcomers. label Sep 16, 2022
@xxchan xxchan closed this as not planned Won't fix, can't repro, duplicate, stale May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty/simple Issues that relatively easy and friendly to newcomers. good first issue Good for newcomers help wanted Issues that need help from contributors type/feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@skyzh @yezizp2012 @BugenZhao @xxchan