Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add some comments for keys & rename keys -> key #3700

Merged
merged 6 commits into from
Jul 7, 2022
Merged

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Jul 6, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

@github-actions github-actions bot added the component/doc Issues about documentation. label Jul 6, 2022
@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #3700 (dc8bf0c) into main (36e2f25) will decrease coverage by 0.01%.
The diff coverage is 78.07%.

@@            Coverage Diff             @@
##             main    #3700      +/-   ##
==========================================
- Coverage   74.32%   74.31%   -0.02%     
==========================================
  Files         792      792              
  Lines      111746   111746              
==========================================
- Hits        83052    83040      -12     
- Misses      28694    28706      +12     
Flag Coverage Δ
rust 74.31% <78.07%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/executor/expand.rs 52.94% <0.00%> (-4.03%) ⬇️
src/batch/src/executor/join/hash_join.rs 84.80% <ø> (ø)
src/batch/src/executor/join/sort_merge_join.rs 70.98% <0.00%> (ø)
src/batch/src/task/hash_shuffle_channel.rs 0.00% <0.00%> (ø)
src/ctl/src/cmd_impl/table/scan.rs 0.00% <0.00%> (ø)
src/frontend/src/catalog/pg_catalog/mod.rs 8.75% <ø> (ø)
...c/frontend/src/optimizer/plan_node/batch_expand.rs 0.00% <0.00%> (ø)
.../frontend/src/optimizer/plan_node/stream_expand.rs 0.00% <0.00%> (ø)
...rc/frontend/src/optimizer/plan_node/stream_topn.rs 54.71% <0.00%> (ø)
...ontend/src/stream_fragmenter/rewrite/delta_join.rs 0.00% <0.00%> (ø)
... and 48 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@mergify mergify bot merged commit 1bb848b into main Jul 7, 2022
@mergify mergify bot deleted the xxchan/doc branch July 7, 2022 04:13
@xiangjinwu
Copy link
Contributor

rename keys -> key: a key is a whole, consisting of multiple columns. So we should call it key instead of keys

At least the keys in expand's subset is not following this definition ... It was used as a synonym of "column index" ... I will take care of fixing the naming there.

nasnoisaac pushed a commit to nasnoisaac/risingwave that referenced this pull request Aug 9, 2022
…3700)

* doc: add some comments for keys

* keys -> key

* keys -> key

* keys -> key

* fix doc link

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/doc Issues about documentation. type/style
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants