-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deliver all-in-one binary to users #552
Comments
Another issue is that, we are using lazy_static everywhere, so there is risk that something will break if we start compute-node, meta-node within one process (e.g., jaeger-all-in-one) |
I didn't know this command very well. So it seems that risingwave symbol is point to meta-node? Emmm it looks strange cuz meta-node is included in risingwave. I guess it can also reduce the download/upload binary in CI? Rest LGTM, but seems like there are not too much aware-able improvement for users (IMO it's kind of optimization), given that our risedev is already handle this. |
meta-node, compute-node, frontend-node are all symbol links of (I might have mistaken the order of the two parameters of ln?) |
Looks like you want to bundle them to one process and use environment variable (option 1) or arg[0] (option 2) to load the correct main entry. I haven't seen this usage before. Does it bring benefits to reducing package size or deployment? |
One program, but not one process.
I guess it would reduce binary size greatly. e.g.,
Indeed, you are using it everyday -- rustc installed by rustup is already leveraging this technique. See "工作原理" in this article for more information: https://note.xuanwo.io/#/page/rustup |
looks fun😄 |
458MB + 318MB + 680MB = 1519MB -> 825MB |
... we've reduced about half the space! |
cockroachdb is all-in-one binary. |
I suggest to add another risingwave-playground binary (command). |
We can pack all of them into
risingwave
, so as to reduce duplicated binary.After that, we can start the binary in one of the ways:
cc @pangzhenzhou @BowenXiao1999 what do you think?
The text was updated successfully, but these errors were encountered: