Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): use all-in-one binary #1067

Merged
merged 5 commits into from
Mar 18, 2022
Merged

feat(ci): use all-in-one binary #1067

merged 5 commits into from
Mar 18, 2022

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented Mar 18, 2022

Signed-off-by: Alex Chi [email protected]

What's changed and what's your intention?

As title

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

ref #552

@skyzh skyzh requested a review from fuyufjh March 18, 2022 07:27
Signed-off-by: Alex Chi <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #1067 (53ebe6b) into main (dd006ec) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1067      +/-   ##
============================================
- Coverage     71.76%   71.70%   -0.06%     
  Complexity     2766     2766              
============================================
  Files           996      996              
  Lines         83745    83810      +65     
  Branches       1790     1790              
============================================
+ Hits          60097    60099       +2     
- Misses        22757    22820      +63     
  Partials        891      891              
Flag Coverage Δ
java 61.01% <ø> (ø)
rust 74.20% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/meta/src/rpc/service/catalog_service_v2.rs 0.00% <0.00%> (ø)
.../src/executor/managed_state/aggregation/extreme.rs 90.40% <0.00%> (+0.27%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

skyzh added 2 commits March 18, 2022 15:41
Signed-off-by: Alex Chi <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in All-In-One!

@skyzh skyzh merged commit e106294 into main Mar 18, 2022
@skyzh skyzh deleted the skyzh/single-binary-ci branch March 18, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants