Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust frontend: support plan select * from x in stream #930

Closed
skyzh opened this issue Mar 15, 2022 · 3 comments
Closed

rust frontend: support plan select * from x in stream #930

skyzh opened this issue Mar 15, 2022 · 3 comments
Assignees

Comments

@skyzh
Copy link
Contributor

skyzh commented Mar 15, 2022

We will convert select * from x in stream to StreamTableScan (not sure if this is correct).

Will finish this function:

impl ToStream for LogicalScan {
    fn to_stream(&self) -> PlanRef {
        todo!()
    }
}
@skyzh skyzh self-assigned this Mar 15, 2022
@st1page st1page mentioned this issue Mar 15, 2022
28 tasks
@st1page
Copy link
Contributor

st1page commented Mar 15, 2022

I think the StreamMaterialize should not be in the to_stream of logicalScan but it should be at the top of the streaming plan, so it should not be in "LogicalScan::to_stream" but in PlanRoot::gen_create_mv_plan

@fuyufjh
Copy link
Member

fuyufjh commented Mar 15, 2022

s/StreamMaterialize/StreamChain/ ?

@skyzh
Copy link
Contributor Author

skyzh commented Mar 15, 2022

I'll implement stream source scan first, and later add chain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants