Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): support stream scan plan #938

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented Mar 15, 2022

Signed-off-by: Alex Chi [email protected]

What's changed and what's your intention?

As title. We will add full support (e.g., chain executor) in the future.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

ref #930

@skyzh skyzh requested a review from st1page March 15, 2022 10:01
@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #938 (c587e98) into main (e3b2814) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #938      +/-   ##
============================================
+ Coverage     71.48%   71.57%   +0.08%     
  Complexity     2766     2766              
============================================
  Files           970      970              
  Lines         56591    56600       +9     
  Branches       1787     1787              
============================================
+ Hits          40456    40510      +54     
+ Misses        15245    15200      -45     
  Partials        890      890              
Flag Coverage Δ
java 61.23% <ø> (ø)
rust 75.56% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t/frontend/src/optimizer/plan_node/logical_scan.rs 100.00% <100.00%> (+3.70%) ⬆️
...frontend/src/optimizer/plan_node/stream_project.rs 69.23% <100.00%> (+69.23%) ⬆️
...end/src/optimizer/plan_node/stream_table_source.rs 100.00% <100.00%> (+100.00%) ⬆️
rust/common/src/types/ordered_float.rs 25.82% <0.00%> (+0.33%) ⬆️
rust/frontend/test_runner/src/lib.rs 72.91% <0.00%> (+1.04%) ⬆️
...rontend/src/optimizer/plan_node/logical_project.rs 97.00% <0.00%> (+2.39%) ⬆️
...frontend/src/optimizer/plan_node/logical_filter.rs 98.38% <0.00%> (+3.22%) ⬆️
...st/frontend/src/optimizer/property/distribution.rs 68.75% <0.00%> (+8.33%) ⬆️
rust/frontend/src/optimizer/mod.rs 95.23% <0.00%> (+9.52%) ⬆️
... and 4 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@@ -106,6 +106,6 @@ impl ToBatch for LogicalScan {

impl ToStream for LogicalScan {
fn to_stream(&self) -> PlanRef {
todo!()
StreamTableSource::new(self.clone()).into()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, we should decide whether to map to TableSource or Chain by the source/mview info from catalog.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that’s true.

@skyzh skyzh merged commit 50a322c into main Mar 15, 2022
@skyzh skyzh deleted the skyzh/support-stream-scan branch March 15, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants