feat: check ref count for drop source #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1057 +/- ##
============================================
- Coverage 71.76% 71.75% -0.01%
Complexity 2766 2766
============================================
Files 995 995
Lines 83665 83675 +10
Branches 1790 1790
============================================
Hits 60041 60041
- Misses 22733 22743 +10
Partials 891 891
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
BugenZhao
approved these changes
Mar 18, 2022
| @@ -20,6 +20,7 @@ pub type DatabaseId = u32; | |||
| pub type SchemaId = u32; | |||
| pub type TableId = u32; | |||
| pub type SourceId = u32; | |||
| pub type RelationId = u32; | |||
There was a problem hiding this comment.
We may refactor this using an enum in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
As title.
Checklist
Refer to a related PR or issue link (optional)