-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace proto sstable meta with self managed struct #1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1447 +/- ##
============================================
+ Coverage 70.17% 70.22% +0.05%
Complexity 2766 2766
============================================
Files 1028 1028
Lines 90065 90151 +86
Branches 1790 1790
============================================
+ Hits 63201 63309 +108
+ Misses 25973 25951 -22
Partials 891 891
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
MrCroxx
changed the title
[WIP] feat: replace proto with self managed serde for sstable meta
[WIP] feat: replace proto sstable meta with self managed
Mar 31, 2022
MrCroxx
changed the title
[WIP] feat: replace proto sstable meta with self managed
feat: replace proto sstable meta with self managed struct
Mar 31, 2022
hzxa21
approved these changes
Mar 31, 2022
BugenZhao
approved these changes
Mar 31, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
Originally we use proto to represent
SstableMeta
, which is unnecessary becauseSstableMeta
is never passed by rpc call. This PR replace protoSstableMeta
with self managedSstableMeta
, after which we can removeSstableMeta
and related proto definitions from proto file.Additionally, new
SstableMeta
contains magic and version field for backward compatibility.Checklist
Refer to a related PR or issue link (optional)