Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace proto sstable meta with self managed struct #1447

Merged
merged 6 commits into from
Mar 31, 2022
Merged

Conversation

MrCroxx
Copy link
Contributor

@MrCroxx MrCroxx commented Mar 31, 2022

What's changed and what's your intention?

Originally we use proto to represent SstableMeta, which is unnecessary because SstableMeta is never passed by rpc call. This PR replace proto SstableMeta with self managed SstableMeta, after which we can remove SstableMeta and related proto definitions from proto file.

Additionally, new SstableMeta contains magic and version field for backward compatibility.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #1447 (d425861) into main (8a40888) will increase coverage by 0.05%.
The diff coverage is 91.05%.

@@             Coverage Diff              @@
##               main    #1447      +/-   ##
============================================
+ Coverage     70.17%   70.22%   +0.05%     
  Complexity     2766     2766              
============================================
  Files          1028     1028              
  Lines         90065    90151      +86     
  Branches       1790     1790              
============================================
+ Hits          63201    63309     +108     
+ Misses        25973    25951      -22     
  Partials        891      891              
Flag Coverage Δ
java 61.01% <ø> (ø)
rust 72.19% <91.05%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/bench/ss_bench/main.rs 0.98% <ø> (+0.01%) ⬆️
rust/common/src/config.rs 75.24% <ø> (+12.25%) ⬆️
rust/meta/src/hummock/test_utils.rs 96.42% <ø> (ø)
rust/storage/src/hummock/block_cache.rs 84.84% <0.00%> (+2.49%) ⬆️
rust/storage/src/hummock/compactor.rs 8.81% <0.00%> (ø)
rust/storage/src/hummock/error.rs 13.46% <ø> (ø)
...rc/hummock/shared_buffer/shared_buffer_uploader.rs 20.72% <0.00%> (ø)
rust/storage/src/hummock/sstable/multi_builder.rs 90.41% <ø> (ø)
rust/storage/src/hummock/test_utils.rs 80.48% <ø> (-0.24%) ⬇️
rust/storage/src/hummock/sstable/mod.rs 91.73% <94.23%> (+15.26%) ⬆️
... and 6 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@MrCroxx MrCroxx changed the title [WIP] feat: replace proto with self managed serde for sstable meta [WIP] feat: replace proto sstable meta with self managed Mar 31, 2022
@MrCroxx MrCroxx changed the title [WIP] feat: replace proto sstable meta with self managed feat: replace proto sstable meta with self managed struct Mar 31, 2022
@MrCroxx MrCroxx marked this pull request as ready for review March 31, 2022 05:46
@MrCroxx MrCroxx self-assigned this Mar 31, 2022
@MrCroxx MrCroxx enabled auto-merge (squash) March 31, 2022 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants