feat: support ROUND, NOT LIKE and EXTRACT #1498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1498 +/- ##
=========================================
Coverage 70.45% 70.46%
Complexity 2766 2766
=========================================
Files 1031 1031
Lines 90539 90590 +51
Branches 1790 1790
=========================================
+ Hits 63792 63835 +43
- Misses 25856 25864 +8
Partials 891 891
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
fuyufjh
changed the title
fuyufjh
approved these changes
Apr 1, 2022
| query T | ||
| values(round(42.4382)); | ||
| ---- | ||
| 42 |
There was a problem hiding this comment.
May also add some e2e tests for not like
There was a problem hiding this comment.
Ok, I will copy some tests from duckdb or elsewhere in later pr.
skyzh
reviewed
Apr 1, 2022
| @@ -0,0 +1,18 @@ | |||
| include ../../tpch/create_tables.slt.part | |||
There was a problem hiding this comment.
may move this file to batch/tpch.slt?
There was a problem hiding this comment.
Well batch/tpch.slt actually includes some tests that's only supported by java frontend. I will totally substitute the old tpch.slt when frontend-v2 are full-featured.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
This PR tried to list the already supported tpch tests. Some were previously blocked by ROUND, NOT LIKE and EXTRACT, which this PR has addressed. Now we have supported q1/q5/q6/q7/q13.
Checklist
Refer to a related PR or issue link (optional)