Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pgwire): Match on char to avoid utf8 convert #1506

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

Xuanwo
Copy link
Contributor

@Xuanwo Xuanwo commented Apr 1, 2022

I hereby agree to the terms of the CLA available at: s9y-cla

Signed-off-by: Xuanwo [email protected]

What's changed and what's your intention?

The convert from &[u8] to &str is not needed, as we can match on the char directly.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

@codecov
Copy link

codecov bot commented Apr 1, 2022

The author of this PR, Xuanwo, is not an activated member of this organization on Codecov.
Please activate this user on Codecov to display this PR comment.
Coverage data is still being uploaded to Codecov.io for purposes of overall coverage calculations.
Please don't hesitate to email us at [email protected] with any questions.

@skyzh
Copy link
Contributor

skyzh commented Apr 1, 2022

Thanks @Xuanwo! As we have not made our repo public yet, the CLA assistant cannot be enabled now. Would you please manually go to this URL https://cla-assistant.io/singularity-data/ and agree on this CLA? Thanks!

@Xuanwo
Copy link
Contributor Author

Xuanwo commented Apr 1, 2022

image

I got a 401 error from https://cla-assistant.io/api/github/call, seems buggy (:

@skyzh
Copy link
Contributor

skyzh commented Apr 1, 2022

Oops, then you may modify your PR body to have one line of text:

I hereby agree to the terms of the CLA available at: s9y-cla

@Xuanwo
Copy link
Contributor Author

Xuanwo commented Apr 1, 2022

Oops, then you may modify your PR body to have one line of text:

I hereby agree to the terms of the CLA available at: s9y-cla

Done

@skyzh skyzh enabled auto-merge (squash) April 1, 2022 04:27
@skyzh skyzh merged commit b00df18 into main Apr 1, 2022
@skyzh skyzh deleted the xuanwo-pgwire-message-cleanup branch April 1, 2022 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants