feat: use entry size as weight in block and meta cache, export cache capacity config #1512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1512 +/- ##
============================================
+ Coverage 70.45% 70.47% +0.01%
Complexity 2766 2766
============================================
Files 1031 1031
Lines 90539 90607 +68
Branches 1790 1790
============================================
+ Hits 63793 63856 +63
- Misses 25855 25860 +5
Partials 891 891
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
twocode
reviewed
Apr 1, 2022
twocode
reviewed
Apr 1, 2022
twocode
approved these changes
Apr 1, 2022
BugenZhao
approved these changes
Apr 1, 2022
| @@ -52,6 +52,8 @@ pub fn mock_sstable_store_with_object_store(object_store: ObjectStoreRef) -> Sst | |||
| object_store, | |||
| path, | |||
| Arc::new(StateStoreMetrics::unused()), | |||
| 64 << 20, | |||
There was a problem hiding this comment.
We may use default::block_cache_capacity() here?
There was a problem hiding this comment.
Or default_config_for_test().block_cache_capacity. 🤣
There was a problem hiding this comment.
The differences between these two configs are big. Let's maintain them separately for now. I think we still need to refactor the test utils later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
Checklist
Refer to a related PR or issue link (optional)