chore: rename java -> legacy #1526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will fix doc links later -- handling too many changes is too hard for me. |
skyzh
requested review from
TennyZhuang and
neverchanje
and removed request for
TennyZhuang
|
Also all Java checks are disabled -- will add back later. |
skyzh
force-pushed
the
skyzh/rename-java-to-legacy
branch
from
3b061c7 to
5905aa1
Compare
BowenXiao1999
approved these changes
Apr 1, 2022
neverchanje
approved these changes
Apr 1, 2022
skyzh
force-pushed
the
skyzh/rename-java-to-legacy
branch
from
5905aa1 to
47ca84d
Compare
skyzh
force-pushed
the
skyzh/rename-java-to-legacy
branch
from
47ca84d to
6c9c126
Compare
Codecov Report
@@ Coverage Diff @@
## main #1526 +/- ##
=========================================
Coverage 70.14% 70.14%
Complexity 2766 2766
=========================================
Files 1031 1031
Lines 90546 90546
Branches 1790 1790
=========================================
+ Hits 63514 63516 +2
+ Misses 26141 26139 -2
Partials 891 891
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
Renaming involves too many changes, so I'd do this in two parts. As no one is currently modifying java path, let's rename it first.
Checklist
Refer to a related PR or issue link (optional)
ref #1092