refactor: extract boolean env var parse #1553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bugen Zhao <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1553 +/- ##
=========================================
Coverage 69.61% 69.62%
Complexity 2766 2766
=========================================
Files 1038 1039 +1
Lines 90816 90822 +6
Branches 1790 1790
=========================================
+ Hits 63226 63233 +7
+ Misses 26699 26698 -1
Partials 891 891
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Signed-off-by: Bugen Zhao <[email protected]>
neverchanje
approved these changes
Apr 2, 2022
xxchan
reviewed
Apr 2, 2022
Comment on lines
-34
to
+35
| static ref IMPLICIT_FLUSH: bool = | ||
| std::env::var("RW_IMPLICIT_FLUSH").unwrap_or_else(|_| { "1".to_string() }) == "1"; | ||
| pub(super) static ref IMPLICIT_FLUSH: bool = env_var_is_true("RW_IMPLICIT_FLUSH"); |
There was a problem hiding this comment.
The old default value is true, but now is false?
There was a problem hiding this comment.
Yep. It should be false. 🤪
Signed-off-by: Bugen Zhao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bugen Zhao [email protected]
What's changed and what's your intention?
As title.
Checklist
Refer to a related PR or issue link (optional)