Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: link to user docs #1594

Merged
merged 1 commit into from
Apr 6, 2022
Merged

docs: link to user docs #1594

merged 1 commit into from
Apr 6, 2022

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented Apr 6, 2022

Signed-off-by: Alex Chi [email protected]

What's changed and what's your intention?

As title

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Signed-off-by: Alex Chi <[email protected]>
@skyzh skyzh requested a review from BugenZhao April 6, 2022 02:58
@github-actions github-actions bot added the component/doc Issues about documentation. label Apr 6, 2022
@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #1594 (4f48d4f) into main (e156ac7) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1594      +/-   ##
============================================
+ Coverage     69.70%   69.73%   +0.02%     
  Complexity     2766     2766              
============================================
  Files          1042     1042              
  Lines         91601    91685      +84     
  Branches       1790     1790              
============================================
+ Hits          63851    63934      +83     
- Misses        26859    26860       +1     
  Partials        891      891              
Flag Coverage Δ
java 61.01% <ø> (ø)
rust 71.55% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/meta/src/hummock/vacuum.rs 84.55% <0.00%> (-0.90%) ⬇️
.../src/executor/managed_state/aggregation/extreme.rs 90.13% <0.00%> (-0.28%) ⬇️
src/meta/src/hummock/hummock_manager_tests.rs 90.28% <0.00%> (-0.21%) ⬇️
src/meta/src/hummock/test_utils.rs 96.71% <0.00%> (+0.28%) ⬆️
src/meta/src/model/mod.rs 99.05% <0.00%> (+0.63%) ⬆️
src/meta/src/hummock/hummock_manager.rs 91.71% <0.00%> (+0.72%) ⬆️
src/connector/src/filesystem/file_common.rs 81.16% <0.00%> (+0.89%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@skyzh skyzh enabled auto-merge (squash) April 6, 2022 03:13
@skyzh skyzh merged commit 03030eb into main Apr 6, 2022
@skyzh skyzh deleted the skyzh/link-docs branch April 6, 2022 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/doc Issues about documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants