Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser): cycle dependency between test runner and parser #1595

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented Apr 6, 2022

Signed-off-by: Alex Chi [email protected]

What's changed and what's your intention?

As title

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@skyzh skyzh requested a review from neverchanje April 6, 2022 03:50
@github-actions github-actions bot added the type/fix Bug fix label Apr 6, 2022
@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #1595 (ee6016a) into main (1b5bfd7) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1595      +/-   ##
============================================
- Coverage     69.89%   69.89%   -0.01%     
  Complexity     2766     2766              
============================================
  Files          1041     1041              
  Lines         91710    91710              
  Branches       1790     1790              
============================================
- Hits          64101    64099       -2     
- Misses        26718    26720       +2     
  Partials        891      891              
Flag Coverage Δ
java 61.01% <ø> (ø)
rust 71.75% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sqlparser/test_runner/src/lib.rs 84.04% <100.00%> (ø)
src/meta/src/manager/stream_clients.rs 88.88% <0.00%> (-7.41%) ⬇️
src/connector/src/filesystem/file_common.rs 79.82% <0.00%> (-1.35%) ⬇️
src/common/src/types/ordered_float.rs 23.70% <0.00%> (+0.19%) ⬆️
.../src/executor/managed_state/aggregation/extreme.rs 90.40% <0.00%> (+0.27%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@skyzh skyzh enabled auto-merge (squash) April 6, 2022 04:02
@skyzh skyzh merged commit 188766f into main Apr 6, 2022
@skyzh skyzh deleted the skyzh/fix-cycle-dependency branch April 6, 2022 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants