Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reduce duplicated code on create source and create table #1665

Merged
merged 6 commits into from
Apr 7, 2022

Conversation

neverchanje
Copy link
Contributor

What's changed and what's your intention?

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #1665 (98f848c) into main (bf74823) will decrease coverage by 0.01%.
The diff coverage is 81.73%.

@@             Coverage Diff              @@
##               main    #1665      +/-   ##
============================================
- Coverage     69.93%   69.92%   -0.02%     
  Complexity     2766     2766              
============================================
  Files          1052     1052              
  Lines         92427    92439      +12     
  Branches       1790     1790              
============================================
- Hits          64638    64637       -1     
- Misses        26898    26911      +13     
  Partials        891      891              
Flag Coverage Δ
java 61.01% <ø> (ø)
rust 71.76% <81.73%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/src/catalog/column.rs 90.38% <ø> (ø)
src/frontend/src/catalog/source_catalog.rs 96.55% <ø> (ø)
src/frontend/src/handler/flush.rs 0.00% <0.00%> (ø)
src/frontend/src/handler/create_source.rs 90.47% <68.88%> (+3.35%) ⬆️
src/frontend/src/catalog/mod.rs 82.14% <72.22%> (-17.86%) ⬇️
src/frontend/src/handler/create_table.rs 96.00% <96.66%> (+2.29%) ⬆️
src/frontend/src/binder/select.rs 94.11% <100.00%> (+3.71%) ⬆️
src/frontend/src/catalog/column_catalog.rs 91.66% <100.00%> (+1.66%) ⬆️
src/frontend/src/catalog/table_catalog.rs 99.43% <100.00%> (-0.07%) ⬇️
src/frontend/src/handler/create_mv.rs 97.82% <100.00%> (-0.14%) ⬇️
... and 13 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@neverchanje neverchanje merged commit 81ce409 into main Apr 7, 2022
@neverchanje neverchanje deleted the wt-refactor branch April 7, 2022 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants