Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: quick fix for create mv ut timeout #1728

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

yezizp2012
Copy link
Member

@yezizp2012 yezizp2012 commented Apr 8, 2022

What's changed and what's your intention?

As title, this happens because of stopping the mock compute service during checkpoint. The barrier manager will enter recovery mode. This PR is a quick fix on this test, and test_create_materialized_view is outdated which need refactor.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Resolve #1722

@CLAassistant
Copy link

CLAassistant commented Apr 8, 2022

CLA assistant check
All committers have signed the CLA.

@yezizp2012 yezizp2012 requested review from BugenZhao and skyzh April 8, 2022 16:58
@github-actions github-actions bot added the type/fix Bug fix label Apr 8, 2022
@yezizp2012 yezizp2012 enabled auto-merge (squash) April 8, 2022 17:00
@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #1728 (2994c6b) into main (124bba4) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1728      +/-   ##
==========================================
- Coverage   71.31%   71.30%   -0.02%     
==========================================
  Files         599      599              
  Lines       77662    77662              
==========================================
- Hits        55384    55375       -9     
- Misses      22278    22287       +9     
Flag Coverage Δ
rust 71.30% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/meta/src/stream/stream_manager.rs 78.52% <100.00%> (ø)
src/meta/src/barrier/command.rs 56.48% <0.00%> (-1.86%) ⬇️
src/meta/src/barrier/mod.rs 73.47% <0.00%> (-1.80%) ⬇️
.../src/executor/managed_state/aggregation/extreme.rs 90.13% <0.00%> (-0.28%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@yezizp2012 yezizp2012 merged commit fe66476 into main Apr 8, 2022
@yezizp2012 yezizp2012 deleted the fix/fix-create-mv-ut-timeout branch April 8, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_create_materialized_view may timeout
4 participants