Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(streaming): migrate TopNExecutor to ExecutorV2 #1737

Merged
merged 1 commit into from
Apr 11, 2022
Merged

Conversation

a9QrX3Lu
Copy link
Contributor

What's changed and what's your intention?

As title.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Close #1735

@CLAassistant
Copy link

CLAassistant commented Apr 10, 2022

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Apr 10, 2022

Codecov Report

Merging #1737 (6547124) into main (01947e4) will decrease coverage by 0.03%.
The diff coverage is 83.73%.

@@            Coverage Diff             @@
##             main    #1737      +/-   ##
==========================================
- Coverage   71.16%   71.12%   -0.04%     
==========================================
  Files         601      603       +2     
  Lines       77950    78066     +116     
==========================================
+ Hits        55470    55527      +57     
- Misses      22480    22539      +59     
Flag Coverage Δ
rust 71.12% <83.73%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/stream/src/executor/top_n.rs 0.00% <0.00%> (-86.53%) ⬇️
src/stream/src/executor_v2/error.rs 0.00% <0.00%> (ø)
src/stream/src/executor_v2/mod.rs 55.81% <ø> (ø)
src/stream/src/executor_v2/v1_compat.rs 38.46% <0.00%> (-5.66%) ⬇️
src/stream/src/executor_v2/top_n_executor.rs 17.39% <17.39%> (ø)
src/stream/src/executor_v2/top_n.rs 90.76% <90.76%> (ø)
src/stream/src/executor/top_n_appendonly.rs 84.53% <100.00%> (ø)
src/connector/src/filesystem/file_common.rs 80.80% <0.00%> (+0.44%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@lmatz lmatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@a9QrX3Lu a9QrX3Lu enabled auto-merge (squash) April 11, 2022 13:58
@a9QrX3Lu a9QrX3Lu merged commit fc93222 into main Apr 11, 2022
@a9QrX3Lu a9QrX3Lu deleted the wzl/top-n-v2 branch April 11, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stream: migrate TopNExecutor to ExecutorV2
3 participants