-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(binder): align type cast-ability with pg #1759
Conversation
a33116d
to
a504dc3
Compare
Codecov Report
@@ Coverage Diff @@
## main #1759 +/- ##
==========================================
+ Coverage 71.12% 71.21% +0.08%
==========================================
Files 604 604
Lines 78094 78261 +167
==========================================
+ Hits 55546 55734 +188
+ Misses 22548 22527 -21
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
a504dc3
to
3e338e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM. Great job!
What's changed and what's your intention?
cast_ok
checks type cast-ability for all 13 types we support so far in a pg-compatible way (Seebuild_cast_map
andtest_cast_ok
for details). It is also aware of cast context.Binder::find_compat
->least_restrictive
ensure_type
->cast_{implicit,assign,explicit}
orFunctionCall::new_cast
FunctionCall::new_with_return_type
should not be abused to bypassinfer_type
. It will be deprecated in a later PR.Checklist
Refer to a related PR or issue link (optional)