feat: apply retry strategy when recovery #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1768 +/- ##
==========================================
- Coverage 71.17% 71.15% -0.02%
==========================================
Files 601 601
Lines 77937 77950 +13
==========================================
- Hits 55469 55468 -1
- Misses 22468 22482 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
BugenZhao
approved these changes
Apr 11, 2022
| loop { | ||
| tokio::time::sleep(Self::RECOVERY_RETRY_INTERVAL).await; | ||
|
|
||
| let retry_category = Self::get_retry_strategy(); |
There was a problem hiding this comment.
Suggested change
| let retry_category = Self::get_retry_strategy(); | |
| let retry_strategy = Self::get_retry_strategy(); |
|
Not noticed that the auto-merging is on. 😢 |
My bad, will fix this in another PR. 😁 |
yezizp2012
changed the title
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
As title, using retry strategy for operation in recovery rather than simple loop and add retry interval for
reset_compute_nodes.Checklist
Refer to a related PR or issue link (optional)