Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing license headers #1777

Merged
merged 3 commits into from
Apr 12, 2022
Merged

Conversation

TennyZhuang
Copy link
Contributor

@TennyZhuang TennyZhuang commented Apr 12, 2022

Signed-off-by: TennyZhuang [email protected]

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

Add missing headers.

Will fix the checker action in the next PR.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@skyzh
Copy link
Contributor

skyzh commented Apr 12, 2022

please install licenseye using the latest hash, so as to use the latest version (guess some goproxy has cache). The current version you are using will have an extra line of //, causing rust-analyzer to insert auto imports to a wrong place.

@TennyZhuang
Copy link
Contributor Author

I've not set the GOPROXY, and install from latest.

github.com/apache/skywalking-eyes/cmd/license-eye@latest

@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #1777 (2401b86) into main (d0a2928) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 2401b86 differs from pull request most recent head 87450eb. Consider uploading reports for the commit 87450eb to get more accurate results

@@            Coverage Diff             @@
##             main    #1777      +/-   ##
==========================================
- Coverage   71.29%   71.29%   -0.01%     
==========================================
  Files         605      605              
  Lines       78599    78599              
==========================================
- Hits        56041    56039       -2     
- Misses      22558    22560       +2     
Flag Coverage Δ
rust 71.29% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/src/alloc.rs 100.00% <ø> (ø)
src/common/src/buffer/bitmap.rs 87.64% <ø> (ø)
src/common/src/buffer/buffer_.rs 78.43% <ø> (ø)
src/frontend/src/binder/expr/subquery.rs 83.33% <ø> (ø)
src/frontend/src/binder/window_table_function.rs 68.60% <ø> (ø)
src/frontend/src/handler/set.rs 0.00% <ø> (ø)
src/frontend/src/meta_client.rs 0.00% <ø> (ø)
src/frontend/src/scheduler/execution/query.rs 0.00% <ø> (ø)
src/frontend/src/scheduler/execution/stage.rs 0.00% <ø> (ø)
src/frontend/src/scheduler/query_manager.rs 7.44% <ø> (ø)
... and 9 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@skyzh
Copy link
Contributor

skyzh commented Apr 12, 2022

I've not set the GOPROXY, and install from latest.

github.com/apache/skywalking-eyes/cmd/license-eye@latest

Use git hash instead of latest 🤣

Signed-off-by: TennyZhuang <[email protected]>
Signed-off-by: TennyZhuang <[email protected]>
@TennyZhuang TennyZhuang enabled auto-merge (squash) April 12, 2022 06:04
@TennyZhuang TennyZhuang merged commit e6dd2bf into main Apr 12, 2022
@TennyZhuang TennyZhuang deleted the chore/add-missing-license-header branch April 12, 2022 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants