Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(stream): refine AggExecutor and Executor #1795

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

TennyZhuang
Copy link
Contributor

Signed-off-by: TennyZhuang [email protected]

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

The relation between Executor and AggExecutor are combinations, not inheritance, so no structure should implement them both.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #1795 (2145601) into main (62aba2a) will increase coverage by 0.00%.
The diff coverage is 39.13%.

@@           Coverage Diff           @@
##             main    #1795   +/-   ##
=======================================
  Coverage   71.22%   71.23%           
=======================================
  Files         605      605           
  Lines       78931    78925    -6     
=======================================
  Hits        56219    56219           
+ Misses      22712    22706    -6     
Flag Coverage Δ
rust 71.23% <39.13%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/stream/src/executor_v2/agg.rs 89.47% <0.00%> (ø)
src/stream/src/executor_v2/hash_agg.rs 94.36% <0.00%> (+0.34%) ⬆️
src/stream/src/executor_v2/global_simple_agg.rs 93.14% <56.25%> (+0.74%) ⬆️
src/stream/src/executor_v2/local_simple_agg.rs 97.67% <100.00%> (+0.90%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@TennyZhuang TennyZhuang merged commit a6621c0 into main Apr 12, 2022
@TennyZhuang TennyZhuang deleted the refactor/simplify-agg-v2 branch April 12, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants